fix(backend): allow non-numeric SKU IDs for legacy Windows products #10

Merged

starkSV merged 1 commit from feat/cf-worker-proxy into main

2026-05-18 12:46:28 +05:30

starkSV commented

2026-05-18 12:46:18 +05:30

(Migrated from github.com)

Closes #9

Summary by CodeRabbit

Bug Fixes
- SKU ID parameter now accepts non-numeric values while maintaining validation checks.
- Enhanced error messages when invalid SKU IDs are submitted.

Replaced strconv.Atoi on sku_id with a permissive allowlist regex (alphanumeric, hyphens, underscores). Older products like Windows 8.1 (#48, #52) return non-integer SKU IDs from Microsoft API, causing the Get Download Links button to fail with 'sku_id must be a numeric value'. Closes #9  ## Summary by CodeRabbit * **Bug Fixes** * SKU ID parameter now accepts non-numeric values while maintaining validation checks. * Enhanced error messages when invalid SKU IDs are submitted.  [![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/starkSV/windows-iso-downloader/pull/10?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)

coderabbitai[bot] commented

2026-05-18 12:46:28 +05:30

(Migrated from github.com)

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9d518034-ec2e-42b1-9056-55a7ddd309e7

📥 Commits

Reviewing files that changed from the base of the PR and between 2e2f9c5c48 and 106e2e2b31.

📒 Files selected for processing (1)

backend/main.go

📝 Walkthrough

Walkthrough

The PR replaces numeric-only validation of the sku_id parameter in the /proxy endpoint with a regex-based character allowlist. A compiled regex validSkuID is added to permit alphanumeric characters, underscores, and hyphens, allowing non-integer SKU IDs such as GUIDs and locale strings to pass validation.

Changes

SKU ID Validation

Layer / File(s)	Summary
Regex-based SKU ID validation `backend/main.go`	A compiled regex pattern `validSkuID` matching `^[a-zA-Z0-9_\-]+$` is introduced at the package level. The `/proxy` endpoint's `sku_id` validation replaces `strconv.Atoi` numeric parsing with a regex match check, returning `400` with `"sku_id contains invalid characters"` on mismatch.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

starkSV/windows-iso-downloader#2: Overlaps directly in the same /proxy endpoint's sku_id validation logic; PR #2 enforces numeric-only validation while this PR permits alphanumeric and special characters via regex.

Poem

🐰 A regex hops where numbers would fail,
Now GUIDs and strings tell their tale,
The SKU ID validation finds its way,
Old numeric walls crumble away! ✨

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/cf-worker-proxy

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

> [!CAUTION] > ## Review failed > > The pull request is closed.  <details> <summary>ℹ️ Recent review info</summary> <details> <summary>⚙️ Run configuration</summary> **Configuration used**: defaults **Review profile**: CHILL **Plan**: Pro Plus **Run ID**: `9d518034-ec2e-42b1-9056-55a7ddd309e7` </details> <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 2e2f9c5c48f48aefd0cbbd2b2b66fe8587aa4365 and 106e2e2b318187f58b9590b573329ebabc7e62ca. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `backend/main.go` </details> </details> ---  <details> <summary>📝 Walkthrough</summary> ## Walkthrough The PR replaces numeric-only validation of the `sku_id` parameter in the `/proxy` endpoint with a regex-based character allowlist. A compiled regex `validSkuID` is added to permit alphanumeric characters, underscores, and hyphens, allowing non-integer SKU IDs such as GUIDs and locale strings to pass validation. ## Changes **SKU ID Validation** | Layer / File(s) | Summary | |---|---| | **Regex-based SKU ID validation** <br> `backend/main.go` | A compiled regex pattern `validSkuID` matching `^[a-zA-Z0-9_\-]+$` is introduced at the package level. The `/proxy` endpoint's `sku_id` validation replaces `strconv.Atoi` numeric parsing with a regex match check, returning `400` with `"sku_id contains invalid characters"` on mismatch. | ## Estimated code review effort 🎯 1 (Trivial) | ⏱️ ~3 minutes ## Possibly related PRs - [starkSV/windows-iso-downloader#2](https://github.com/starkSV/windows-iso-downloader/pull/2): Overlaps directly in the same `/proxy` endpoint's `sku_id` validation logic; PR `#2` enforces numeric-only validation while this PR permits alphanumeric and special characters via regex. ## Poem > 🐰 A regex hops where numbers would fail, > Now GUIDs and strings tell their tale, > The SKU ID validation finds its way, > Old numeric walls crumble away! ✨ </details>   <details> <summary>✨ Finishing Touches</summary> <details> <summary>📝 Generate docstrings</summary> - [ ]  Create stacked PR - [ ]  Commit on current branch </details> <details> <summary>🧪 Generate unit tests (beta)</summary> - [ ]  Create PR with unit tests - [ ]  Commit unit tests in branch `feat/cf-worker-proxy` </details> </details>   > [!WARNING] > There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. > > <details> > <summary>🔧 golangci-lint (2.12.2)</summary> > > level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" > > > > > </details>   --- <sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub>