fix(backend): "sku_id must be a numeric value" error on Windows 8.1 products (#48, #52) #9

Closed
opened 2026-05-18 12:44:48 +05:30 by starkSV · 0 comments
starkSV commented 2026-05-18 12:44:48 +05:30 (Migrated from github.com)

Bug

Clicking "Get Download Links" on Windows 8.1 (product/52) and
Windows 8.1 Single Language (product/48) returns:

sku_id must be a numeric value

Root cause

The backend validates sku_id with strconv.Atoi, requiring it to be
a plain integer. Older Windows products return non-integer SKU IDs from
Microsoft's API (e.g. locale strings or GUIDs).

Fix

Replace the strconv.Atoi check with a permissive allowlist regex
^[a-zA-Z0-9_\-]+$ that accepts integers, GUIDs, and locale strings
while still blocking dangerous characters.

## Bug Clicking "Get Download Links" on Windows 8.1 (product/52) and Windows 8.1 Single Language (product/48) returns: > sku_id must be a numeric value ## Root cause The backend validates `sku_id` with `strconv.Atoi`, requiring it to be a plain integer. Older Windows products return non-integer SKU IDs from Microsoft's API (e.g. locale strings or GUIDs). ## Fix Replace the `strconv.Atoi` check with a permissive allowlist regex `^[a-zA-Z0-9_\-]+$` that accepts integers, GUIDs, and locale strings while still blocking dangerous characters.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: shekhar/windows-iso-downloader#9
No description provided.