fix(frontend): fix TypeScript error in Back button navigate call #8

Merged

starkSV merged 1 commit from feat/cf-worker-proxy into main

2026-05-18 12:12:28 +05:30

starkSV commented

2026-05-18 12:12:18 +05:30

(Migrated from github.com)

Summary by CodeRabbit

Refactor
- Improved code structure in the product detail page navigation logic with no impact to user experience.

Split ternary into two separate navigate() calls to satisfy TypeScript overload resolution — navigate(delta: number) and navigate(to: To) are distinct overloads that cannot share a ternary return type.  ## Summary by CodeRabbit * **Refactor** * Improved code structure in the product detail page navigation logic with no impact to user experience.  [![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/starkSV/windows-iso-downloader/pull/8?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)

coderabbitai[bot] commented

2026-05-18 12:12:29 +05:30

(Migrated from github.com)

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 86ba26b9-0409-4f6b-9e30-966423ce90a6

📥 Commits

Reviewing files that changed from the base of the PR and between 2e05348a97 and e7b0fea94b.

📒 Files selected for processing (1)

frontend/src/pages/ProductDetailPage.tsx

📝 Walkthrough

Walkthrough

The back button click handler in ProductDetailPage is refactored to invoke the appropriate navigation function based on browser history state: navigate(-1) when history state is available, otherwise navigate('/').

Changes

Back Button Navigation Refactor

Layer / File(s)	Summary
Back button conditional navigation `frontend/src/pages/ProductDetailPage.tsx`	The onClick handler for the back button now uses an inline ternary expression to choose between `navigate(-1)` and `navigate('/')` based on the presence of `window.history.state?.idx`, improving control-flow clarity.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops back through the page,
No history? Home is the stage—
Logic now clear in each branch,
One line refined with a crunch! 🐰✨

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/cf-worker-proxy

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

> [!CAUTION] > ## Review failed > > The pull request is closed.  <details> <summary>ℹ️ Recent review info</summary> <details> <summary>⚙️ Run configuration</summary> **Configuration used**: defaults **Review profile**: CHILL **Plan**: Pro Plus **Run ID**: `86ba26b9-0409-4f6b-9e30-966423ce90a6` </details> <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between 2e05348a971329834fa09e585fcbbf25f2576c51 and e7b0fea94b0c9347c25d489dcb30e00f9864b662. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `frontend/src/pages/ProductDetailPage.tsx` </details> </details> ---  <details> <summary>📝 Walkthrough</summary> ## Walkthrough The back button click handler in `ProductDetailPage` is refactored to invoke the appropriate navigation function based on browser history state: `navigate(-1)` when history state is available, otherwise `navigate('/')`. ## Changes **Back Button Navigation Refactor** | Layer / File(s) | Summary | |---|---| | **Back button conditional navigation** <br> `frontend/src/pages/ProductDetailPage.tsx` | The onClick handler for the back button now uses an inline ternary expression to choose between `navigate(-1)` and `navigate('/')` based on the presence of `window.history.state?.idx`, improving control-flow clarity. | ## Estimated code review effort 🎯 1 (Trivial) | ⏱️ ~3 minutes ## Poem > A rabbit hops back through the page, > No history? Home is the stage— > Logic now clear in each branch, > One line refined with a crunch! 🐰✨ </details>   <details> <summary>✨ Finishing Touches</summary> <details> <summary>📝 Generate docstrings</summary> - [ ]  Create stacked PR - [ ]  Commit on current branch </details> <details> <summary>🧪 Generate unit tests (beta)</summary> - [ ]  Create PR with unit tests - [ ]  Commit unit tests in branch `feat/cf-worker-proxy` </details> </details>   --- <sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub>