feat: new-release detector tools + missing 25H2 V2 China catalog entries #36
No reviewers
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: shekhar/windows-iso-downloader#36
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "feat/check-new-releases-script"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
scripts/check-new-releases/with two complementary tools for finding Windows product edition IDs that exist on Microsoft's side but aren't yet in the catalog: Method 1 (msdls_v3.py, moved from repo root, range-scan) and Method 2 (main.go, auto-discovery via page-scrape). Both documented in that directory's README.msdls_v3.py's release-name extraction (checked non-existentEditionName/ReleaseName/FriendlyNamefields; real field isProductDisplayName) and adds the missingvlscppesession-permit call.3322/3323/3325/3326(Home/Pro China variants of the 25H2 "V2" refresh) exist on Microsoft's side but weren't in our catalog. Added acrosscli/catalog.go,frontend/public/data/products.json,backend/main.go'svalidContributeProducts,README.md, andfrontend/public/sitemap.xml. Also renamed 3321/3324 from our own guessed "(Updated Oct)" label to Microsoft's real "(V2)" name.Test plan
go build ./...andgo test ./...pass forcli/(21 catalog entries, up from 17)go buildpasses forbackend/products.jsonvalidated as valid JSON/contributeaccepts the new product IDsCo-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Summary by CodeRabbit
New Features
Updates
Actionable comments posted: 2
🧹 Nitpick comments (1)
🤖 Prompt for all review comments with AI agents
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID:
b6e3a20e-065d-475e-8fc4-50beeec56c18📥 Commits
Reviewing files that changed from the base of the PR and between
f67fe84348andc30c2d2b3b.📒 Files selected for processing (9)
README.mdbackend/main.gocli/catalog.gofrontend/public/data/products.jsonfrontend/public/sitemap.xmlscripts/check-new-releases/README.mdscripts/check-new-releases/go.modscripts/check-new-releases/main.goscripts/check-new-releases/msdls_v3.py@ -290,2 +288,4 @@| Windows 11 25H2 (V2) | 3321 | x64 || Windows 11 25H2 (V2) | 3324 | ARM64 || Windows 11 24H2 | 3113 | x64 || Windows 11 24H2 | 3131 | ARM64 |📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add the missing China variants to the catalog table.
The PR objectives mention adding the catalog entries for the Windows 11 25H2 V2 China variants (
3322,3323,3325,3326) to the README, but they are missing from this table.📝 Proposed additions
📝 Committable suggestion
🤖 Prompt for AI Agents
@ -0,0 +140,4 @@client.Do(req3)}return client, sessionID}🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
Close response bodies to prevent resource leaks.
When
client.Doreturns successfully, theResponse.Bodymust be closed to avoid leaking the underlying HTTP connection. Although this is a short-lived script, it is best practice to close the response bodies forreq1andreq3.🛠️ Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents