shekhar/windows-iso-downloader
1
0
Fork 0
Code Issues Pull requests Projects Releases 15 Packages Wiki Activity Actions

fix(cli): use plain "English" in --lang examples, not "English (United States)"

Browse source 
Consumer Windows products list their English option as "English" (or
"English International"), not "English (United States)" -- the exact
example this used, which is why it was such a common source of --lang
mismatch errors. Applies to --help, the --lang flag description, and
the release workflow's usage example.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Shekhar Vaidya 2026-07-13 11:27:12 +05:30
parent 6e374e6a45
commit b1ee80f9b6
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.github/workflows/cli-release.yml vendored
View file

@ -90,7 +90,7 @@ jobs:
``` ```
msdl # fully interactive (includes Server/Enterprise) msdl # fully interactive (includes Server/Enterprise)
msdl "windows 11 25h2" # filter products, pick language msdl "windows 11 25h2" # filter products, pick language
msdl --id 3262 --lang "English (United States)" # direct, no prompts msdl --id 3262 --lang "English" # direct, no prompts
msdl --eval server-2025 # evaluation ISOs directly msdl --eval server-2025 # evaluation ISOs directly
msdl --list # list all products msdl --list # list all products
``` ```

4
cli/main.go
View file

@ -167,7 +167,7 @@ func run(args []string) error {
Usage: Usage:
msdl [search terms] interactive: filter + pick product, pick language msdl [search terms] interactive: filter + pick product, pick language
msdl --id 3262 skip product picker msdl --id 3262 skip product picker
msdl --id 3262 --lang "English (United States)" no prompts, print URL directly msdl --id 3262 --lang "English" no prompts, print URL directly
(language names vary by product — omit --lang (language names vary by product — omit --lang
or check the error's "available" list to see them) or check the error's "available" list to see them)
msdl --eval [slug] evaluation ISOs (server-2025, win11-ent, ...) msdl --eval [slug] evaluation ISOs (server-2025, win11-ent, ...)
@ -185,7 +185,7 @@ More info: https://msdl.tech-latest.com/cli`)
} }
productID := fs.String("id", "", "consumer product ID (skips product picker)") productID := fs.String("id", "", "consumer product ID (skips product picker)")
langFlag := fs.String("lang", "", `language name, e.g. "English (United States)"`) langFlag := fs.String("lang", "", `language name, e.g. "English"`)
evalMode := fs.Bool("eval", false, "fetch evaluation ISOs") evalMode := fs.Bool("eval", false, "fetch evaluation ISOs")
listMode := fs.Bool("list", false, "list all products and exit") listMode := fs.Bool("list", false, "list all products and exit")
noContributeFlag := fs.Bool("no-contribute", false, "skip sharing the link with the msdl.tech cache") noContributeFlag := fs.Bool("no-contribute", false, "skip sharing the link with the msdl.tech cache")