shekhar/windows-iso-downloader
1
0
Fork 0
Code Issues Pull requests Projects Releases 15 Packages Wiki Activity Actions

fix: use extractRawExpiry for /contribute expiry validation

Browse source 
parseLinkExpiry has a 1h safety floor that causes it to treat already-
expired URLs as valid. Replace with extractRawExpiry + direct se
timestamp comparison so any URL expiring < 1h out is rejected.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Shekhar Vaidya 2026-06-18 16:12:36 +05:30
parent 9a5f41290d
commit 36c875ab23
1 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
backend/main.go
View file

@ -1274,13 +1274,22 @@ func handleContribute(w http.ResponseWriter, r *http.Request) {
return
}
// Validation 3: expiry must be > 1 hour out
expiresAt := parseLinkExpiry(raw)
if time.Until(expiresAt) < time.Hour {
log.Printf("contribute: product_id=%s sku_id=%s -> rejected (expiry < 1h)\n", productID, skuID)
// Validation 3: expiry must be > 1 hour out.
// Use extractRawExpiry (direct se timestamp) — NOT parseLinkExpiry, which has
// a 1h safety floor that would accept already-expired URLs.
seStr := extractRawExpiry(raw)
if seStr == "" {
log.Printf("contribute: product_id=%s sku_id=%s -> rejected (no valid se param)\n", productID, skuID)
respondJSONError(w, http.StatusUnprocessableEntity, "no valid signed expiry found in download URL")
return
}
seTime, _ := time.Parse(time.RFC3339, seStr)
if time.Until(seTime) < time.Hour {
log.Printf("contribute: product_id=%s sku_id=%s -> rejected (expiry < 1h: %s)\n", productID, skuID, seStr)
respondJSONError(w, http.StatusUnprocessableEntity, "link expires in less than 1 hour")
return
}
expiresAt := parseLinkExpiry(raw) // cache TTL (se minus 30m buffer + jitter)
// Validation 4: all download URLs must be from allowed Microsoft CDN hosts
var data map[string]interface{}