shekhar/windows-iso-downloader
1
0
Fork 0
Code Issues Pull requests Projects Releases 15 Packages Wiki Activity Actions

fix(cli): guard empty slices in pickers, propagate scanner I/O errors

Browse source
This commit is contained in:
Shekhar Vaidya 2026-06-18 12:01:13 +05:30
parent e8a4be2698
commit 2f93726ec9
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
cli/picker.go
View file

@ -13,6 +13,9 @@ import (
func parseChoice(r io.Reader, max int) (int, error) {
scanner := bufio.NewScanner(r)
if !scanner.Scan() {
if err := scanner.Err(); err != nil {
return 0, fmt.Errorf("reading input: %w", err)
}
return 0, fmt.Errorf("no input")
}
text := strings.TrimSpace(scanner.Text())
@ -27,6 +30,9 @@ func parseChoice(r io.Reader, max int) (int, error) {
}
func pickProduct(products []Product) (Product, error) {
if len(products) == 0 {
return Product{}, fmt.Errorf("no products available")
}
fmt.Fprintln(os.Stderr, "\nSelect a product:")
for i, p := range products {
fmt.Fprintf(os.Stderr, " %2d. %s\n", i+1, p.Name)
@ -40,6 +46,9 @@ func pickProduct(products []Product) (Product, error) {
}
func pickLanguage(langs []Language) (Language, error) {
if len(langs) == 0 {
return Language{}, fmt.Errorf("no languages available")
}
fmt.Fprintln(os.Stderr, "\nSelect a language:")
for i, l := range langs {
fmt.Fprintf(os.Stderr, " %2d. %s\n", i+1, l.Language)
@ -53,6 +62,9 @@ func pickLanguage(langs []Language) (Language, error) {
}
func pickEvalProduct(products []EvalProduct) (EvalProduct, error) {
if len(products) == 0 {
return EvalProduct{}, fmt.Errorf("no eval products available")
}
fmt.Fprintln(os.Stderr, "\nSelect an evaluation product:")
for i, p := range products {
fmt.Fprintf(os.Stderr, " %2d. %s\n", i+1, p.Name)