shekhar/windows-iso-downloader
1
0
Fork 0
Code Issues Pull requests Projects Releases 15 Packages Wiki Activity Actions

Merge pull request #29 from starkSV/feat/sentinel-distinct-sources

Browse source 
feat(backend): approximate distinct-source count for Sentinel rejections
This commit is contained in:
Shekhar 2026-07-13 12:46:06 +05:30 • committed by GitHub
commit 1432cb3158
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 29 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
backend/main.go
View file

@ -937,7 +937,6 @@ func fetchDownloadLinksFromMS(productID, skuID string) ([]byte, error) {
jar = &simpleCookieJar{} jar = &simpleCookieJar{}
} }
proxyQ := url.Values{} proxyQ := url.Values{}
proxyQ.Set("profile", PROFILE) proxyQ.Set("profile", PROFILE)
proxyQ.Set("productEditionId", "undefined") proxyQ.Set("productEditionId", "undefined")
@ -1675,6 +1674,15 @@ func handleTelemetry(w http.ResponseWriter, r *http.Request) {
rdb.HIncrBy(ctx, "msdl:telemetry:results", result, 1) rdb.HIncrBy(ctx, "msdl:telemetry:results", result, 1)
if !p.Success && p.Error != "" && len(p.Error) <= 200 { if !p.Success && p.Error != "" && len(p.Error) <= 200 {
rdb.HIncrBy(ctx, "msdl:telemetry:errors", p.Error, 1) rdb.HIncrBy(ctx, "msdl:telemetry:errors", p.Error, 1)
if strings.Contains(p.Error, "Sentinel") {
// All-time Sentinel-rejection count, plus an approximate
// distinct-source count (via HyperLogLog on the reporting
// IP) so /metrics can show whether rejections are
// concentrated in a few sources or spread across many,
// without ever storing raw IPs.
rdb.Incr(ctx, "msdl:telemetry:sentinel_count")
rdb.PFAdd(ctx, "msdl:telemetry:sentinel_hll", ip)
}
} }
} }
@ -1775,6 +1783,7 @@ func handleMetrics(w http.ResponseWriter, r *http.Request) {
evalCacheMu.RUnlock() evalCacheMu.RUnlock()
telemetry := loadTelemetryFromRedis() telemetry := loadTelemetryFromRedis()
sentinelErrors, sentinelDistinctSources := loadSentinelStatsFromRedis()
w.Header().Set("Content-Type", "application/json") w.Header().Set("Content-Type", "application/json")
json.NewEncoder(w).Encode(map[string]interface{}{ json.NewEncoder(w).Encode(map[string]interface{}{
@ -1802,12 +1811,28 @@ func handleMetrics(w http.ResponseWriter, r *http.Request) {
"hit_rate": hitRate(evalHits, evalReqs), "hit_rate": hitRate(evalHits, evalReqs),
"cache_size": evalSize, "cache_size": evalSize,
}, },
"neg_cache_size": negSize, "neg_cache_size": negSize,
"total_ms_fetches": skuFetches + linkFetches, "total_ms_fetches": skuFetches + linkFetches,
"telemetry": telemetry, "telemetry": telemetry,
"sentinel_errors": sentinelErrors,
"sentinel_distinct_sources_est": sentinelDistinctSources,
}) })
} }
// loadSentinelStatsFromRedis returns the all-time Sentinel-rejection count
// and an approximate distinct-source count (from the HyperLogLog seeded in
// handleTelemetry). Returns (0, 0) when Redis is unavailable.
func loadSentinelStatsFromRedis() (int64, int64) {
if rdb == nil {
return 0, 0
}
ctx, cancel := context.WithTimeout(context.Background(), 500*time.Millisecond)
defer cancel()
count, _ := rdb.Get(ctx, "msdl:telemetry:sentinel_count").Int64()
distinct, _ := rdb.PFCount(ctx, "msdl:telemetry:sentinel_hll").Result()
return count, distinct
}
func warmEvalCache() { func warmEvalCache() {
for slug, product := range evalProductMap { for slug, product := range evalProductMap {
go func(s string, p EvalProduct) { go func(s string, p EvalProduct) {